camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10585) the URL format should include the topic name like the ActiiveMQ & AMQP endpoints
Date Tue, 14 Feb 2017 11:07:41 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865593#comment-15865593
] 

ASF GitHub Bot commented on CAMEL-10585:
----------------------------------------

GitHub user godbolerr opened a pull request:

    https://github.com/apache/camel/pull/1463

    CAMEL-10585: Changes to URL format to include topic name and default …

    Implemented changes as per description. 
    
    If this pattern is not followed for URI, original URI is still valid.
    
    1. Unit tests related to change is passing but unit test related to some other functionality
is failing. Need to check on the same. [KafkaConsumerOffsetRepositoryEmptyTest]
    2. mvn clean install -Psourcecheck results in the following error which was present in
the initial codebase as well.
    
    KafkaComponentTest.java:21: Wrong order for 'java.util.HashMap' import. [ImportOrder]


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godbolerr/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1463
    
----
commit 8f9a69516adbf4be952cca86c78f72d4ddc14092
Author: admin <admin@test.com>
Date:   2017-02-14T11:00:32Z

    CAMEL-10585: Changes to URL format to include topic name and default port

----


> the URL format should include the topic name like the ActiiveMQ & AMQP endpoints
> --------------------------------------------------------------------------------
>
>                 Key: CAMEL-10585
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10585
>             Project: Camel
>          Issue Type: Improvement
>          Components: kafka
>            Reporter: james strachan
>
> it would be nice to be able to use a URL more like ActiveMQ when working with kafka.
e.g.
> {code}
> kafka:serverName:port/topicName
> {code}
> also missing off the port if its not the default port (9092) would be nice too
> {code}
> kafka:serverName/topicName
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message