camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10739) camel-bindy: Unmarshall CSV fields with crlf characters
Date Mon, 23 Jan 2017 06:38:26 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833966#comment-15833966
] 

ASF GitHub Bot commented on CAMEL-10739:
----------------------------------------

GitHub user allancth opened a pull request:

    https://github.com/apache/camel/pull/1420

    CAMEL-10739: camel-bindy: Unmarshall CSV fields with crlf characters

    Bindy CSV currently performs line by line scan, and split with provided delimiter ("comma
by default"), thus unable to recognize if CSV fields might contain crlf characters.
    
    Suggestion, add "multiLine" in @CsvRecord, which BindyCsvDataFormat will parse CSV with
commons-csv library if multi line is true.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/allancth/camel CAMEL-10739

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1420
    
----
commit ed73f63dab6f4c60f4b6acfca8a7f1fb93181e32
Author: Allan C <allancth@gmail.com>
Date:   2017-01-23T06:35:51Z

    CAMEL-10739: camel-bindy: Unmarshall CSV fields with crlf characters

----


> camel-bindy: Unmarshall CSV fields with crlf characters
> -------------------------------------------------------
>
>                 Key: CAMEL-10739
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10739
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>            Reporter: Allan Cheong Tyng Huei
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.19.0
>
>         Attachments: CAMEL-10739.patch, CAMEL-10739-test-case.zip
>
>
> Bindy CSV currently performs line by line scan, and split with provided delimiter ("comma
by default"), thus unable to recognize if CSV fields might contain crlf characters.
> Suggestion, add "multiLine" in @CsvRecord, which BindyCsvDataFormat will parse CSV with
commons-csv library if multi line is true.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message