camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10546) CamelContext - Rename getProperties to getConfiguration
Date Sun, 22 Jan 2017 16:43:27 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833600#comment-15833600
] 

ASF GitHub Bot commented on CAMEL-10546:
----------------------------------------

GitHub user aldettinger opened a pull request:

    https://github.com/apache/camel/pull/1419

    CAMEL-10546: Continued the deprecation of CamelContext.getProperties()

    + properties and globalOptions coexist in schemas
    + globalOptions override existing properties
    + I first deprecated PropertyDefinition but rolled this back in the **third** commit when
I realized it is duly used for endpoint level properties
    + I couldn't help with re-writing GlobalOptionsDefinition.asMap()
    + I didn't completed camel-spring-boot as it looks like the functionality behind "properties"
would be implemented in CamelConfigurationProperties with spring boot. Not sure about that
however, guidance is welcome if need be.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aldettinger/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1419
    
----
commit 5c30671de4525d4fedd9aa220ac03ec84a0286fd
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-19T15:14:23Z

    CAMEL-10546: Deprecated PropertiesDefinition in camel-core

commit 75c80032b1bb5ecbcbd8f3984a61c71062531969
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-19T15:17:11Z

    CAMEL-10546: Added a test for GlobalOptionsDefinition in camel-core

commit 92c971bca8d4ca6c99b996f0682f24cb7f3c63ac
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-19T17:09:15Z

    CAMEL-10546: Removed spring xsd polluting javadoc and rolled back the deprecation of PropertyDefinition
as its used in purpose for endpoint propertiese

commit 97852662f07da1ba4f323af7176e6ad0648e4024
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-19T18:28:46Z

    CAMEL-10546: Added globalOptions to spring and blueprint schema, globalOptions merge/override
properties

commit cb45fb2d193c63254c99298d74dfbd0e82ac6fc8
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-20T12:59:59Z

    CAMEL-10546: Re-written GlobalOptionsDefinition.asMap() more concisely.

commit 6e459867298ada3338748be32521db9d3d39562b
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-21T11:55:49Z

    CAMEL-10546: Completed with a spring xml test

commit 35c4eb91f35d8703824e3987655f43bb7595dedc
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-21T13:06:20Z

    CAMEL-10546: Deprecated getProperties() from the camel context management bean

commit ea9aa639031709b5945a897c5a1e89d3e2d96bdb
Author: aldettinger <aldettinger@gmail.com>
Date:   2017-01-22T16:18:15Z

    CAMEL-10546: Remove the use of the deprecated api in camel-spring-boot

----


> CamelContext - Rename getProperties to getConfiguration
> -------------------------------------------------------
>
>                 Key: CAMEL-10546
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10546
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.19.0
>
>
> People may mistake this with property placeholders. However its used for generic key/value
pairs for configuring some global options on CamelContext such as max debug log length etc.
> An alternative is to change this configuration to be a type safe configuration which
then adds fluent DSL support in Java and also in XML.
> But for 2.x we could add methods called getConfiguration() / setConfiguration() and deprecate
the older methods so people get more aware of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message