camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10606) Modify quartz2 endpoint to be a singleton
Date Thu, 15 Dec 2016 16:56:58 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15751862#comment-15751862
] 

ASF GitHub Bot commented on CAMEL-10606:
----------------------------------------

Github user jamesnetherton closed the pull request at:

    https://github.com/apache/camel/pull/1350


> Modify quartz2 endpoint to be a singleton
> -----------------------------------------
>
>                 Key: CAMEL-10606
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10606
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-quartz2
>            Reporter: James Netherton
>            Assignee: James Netherton
>             Fix For: 2.17.5, 2.18.2, 2.19.0
>
>
> Currently the quartz2 endpoint implements isSingleton() and returns false.
> This causes issues if you try to do something like:
> {code}
> camelContext.getEndpoint("quartz2://foo?cron=5+*+*+*+*")
> {code}
> Which can trigger the endpoint start() method to be called and results in:
> {code}
> Caused by: java.lang.IllegalArgumentException: Trigger key myGroup.longPeriodTimer is
already in use by quartz2://foo/longPeriodTimer?cron=5+*+*+*+*
> 	at org.apache.camel.component.quartz2.QuartzEndpoint.ensureNoDupTriggerKey(QuartzEndpoint.java:446)
> 	at org.apache.camel.component.quartz2.QuartzEndpoint.addJobInScheduler(QuartzEndpoint.java:380)
> 	at org.apache.camel.component.quartz2.QuartzEndpoint.doStart(QuartzEndpoint.java:340)
> {code}
> The quartz1 endpoint implements isSingleton to return true. I see no reason why quartz2
should be any different.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message