camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10086) Remove Pattern.compile usages
Date Tue, 06 Dec 2016 11:11:33 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725054#comment-15725054
] 

ASF GitHub Bot commented on CAMEL-10086:
----------------------------------------

Github user aefox closed the pull request at:

    https://github.com/apache/camel/pull/1332


> Remove Pattern.compile usages
> -----------------------------
>
>                 Key: CAMEL-10086
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10086
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Mateusz Nowakowski
>            Priority: Minor
>             Fix For: Future
>
>
> Please heck Pattern.compile usage across Camel source code - also *not* direct usage.
> For example: 
> Whenever one of these methods are used from String class a Pattern.compile() is utilized:
> - matches
> - replaceFirst
> - replaceAll
> - replace
> - split: has an optimization and for certain characters it doesn’t use Pattern.compile.
> For example:
> GenericFileConsumer.isMatched calls name.matches(endpoint.getExclude())
> GenericFileEndpoint could contain also excludePattern as well.
> Possible solution:
> Walk through the code and replace usages of these methods with static Pattern variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message