Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F3BFC200BCA for ; Mon, 21 Nov 2016 12:51:59 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F2EE4160B19; Mon, 21 Nov 2016 11:51:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 51D9B160AEC for ; Mon, 21 Nov 2016 12:51:59 +0100 (CET) Received: (qmail 61682 invoked by uid 500); 21 Nov 2016 11:51:58 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 61665 invoked by uid 99); 21 Nov 2016 11:51:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Nov 2016 11:51:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 5C0522C4C70 for ; Mon, 21 Nov 2016 11:51:58 +0000 (UTC) Date: Mon, 21 Nov 2016 11:51:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CAMEL-10500) Camel-Git: Add allowEmpty commits option MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 21 Nov 2016 11:52:00 -0000 [ https://issues.apache.org/jira/browse/CAMEL-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683384#comment-15683384 ] ASF GitHub Bot commented on CAMEL-10500: ---------------------------------------- GitHub user chenapan opened a pull request: https://github.com/apache/camel/pull/1284 CAMEL-10500 Camel-Git: Add allowEmpty commits option You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenapan/camel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1284 ---- commit fa09f3ef6f74badb8b18f6a94d93921b743a1235 Author: Olivier Antibi Date: 2016-11-20T21:43:15Z Add allowEmpty endpoint option commit 25a92fd0257106fe36a5e4bcb0e58268a8db777b Author: Olivier Antibi Date: 2016-11-21T10:31:28Z CAMEL-10500 : Camel-Git: Add allowEmpty commits option Formatting and check style ---- > Camel-Git: Add allowEmpty commits option > ----------------------------------------- > > Key: CAMEL-10500 > URL: https://issues.apache.org/jira/browse/CAMEL-10500 > Project: Camel > Issue Type: Improvement > Components: camel-git > Affects Versions: 2.18.0 > Reporter: Olivier Antibi > Assignee: Andrea Cosentino > Priority: Trivial > Fix For: 2.19.0 > > Original Estimate: 2h > Remaining Estimate: 2h > > By default, JGit behaves differently than native git allowing empty commits. This first change is to add a new option to the GitEndpoint to be able to turn that option to false. I let it default to "true" in a first move to have backward compatibility but suggest we could default to "false" to match native git behaviour (git commit --allow-empty) > This will raise an exception for empty commits, may be a silent mode to log warn would be a better option rather than doing error handling in camel. -- This message was sent by Atlassian JIRA (v6.3.4#6332)