Return-Path: <issues-return-36758-archive-asf-public=cust-asf.ponee.io@camel.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3EFDC200BC2
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  2 Nov 2016 12:13:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 3DAB3160AFB; Wed,  2 Nov 2016 11:13:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 83A24160B0A
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  2 Nov 2016 12:12:59 +0100 (CET)
Received: (qmail 65264 invoked by uid 500); 2 Nov 2016 11:12:58 -0000
Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@camel.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@camel.apache.org>
List-Post: <mailto:issues@camel.apache.org>
List-Id: <issues.camel.apache.org>
Reply-To: dev@camel.apache.org
Delivered-To: mailing list issues@camel.apache.org
Received: (qmail 65245 invoked by uid 99); 2 Nov 2016 11:12:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 11:12:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 5BE412C1F5A
	for <issues@camel.apache.org>; Wed,  2 Nov 2016 11:12:58 +0000 (UTC)
Date: Wed, 2 Nov 2016 11:12:58 +0000 (UTC)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.13017066.1478051297000.156641.1478085178373@Atlassian.JIRA>
In-Reply-To: <JIRA.13017066.1478051297000@Atlassian.JIRA>
References: <JIRA.13017066.1478051297000@Atlassian.JIRA> <JIRA.13017066.1478051297196@arcas>
Subject: [jira] [Resolved] (CAMEL-10433) The camel-jetty, camel-jetty9
 feature should explicitly define the expected feature version range for
 jetty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Wed, 02 Nov 2016 11:13:00 -0000


     [ https://issues.apache.org/jira/browse/CAMEL-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider resolved CAMEL-10433.
-----------------------------------------
       Resolution: Fixed
    Fix Version/s: 2.16.5
                   2.17.4

I did not mean to commit in spite of Andrea's comments. I only checked the issue before the merge. At that point there were no comments. I always try to discuss before the commit if there is a controversy.

In the meantime Andrea and I resolved the issue on IRC. We agreed on this:
The change is not be necessary if people follow the karaf guidelines but it should not do any harm. So we can keep the commit.


> The camel-jetty, camel-jetty9 feature should explicitly define the expected feature version range for jetty
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-10433
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10433
>             Project: Camel
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 2.16.3, 2.17.3
>         Environment: Java 8
>            Reporter: Xilai Dai
>            Assignee: Christian Schneider
>            Priority: Minor
>             Fix For: 2.17.4, 2.16.5
>
>
> There is no version range restriction of jetty feature in the camel-jetty and camel-jetty9 feature definition.
> {code}
>     <feature>jetty</feature>
> {code}
> For camel-jetty9 feature, it maybe should add version range like this:
> {code}
>     <feature version='[9,10)'>jetty</feature>
> {code}
> For camel-jetty feature, it maybe should add version range like this:
> {code}
>     <feature version='[8,9)'>jetty</feature>
> {code}
> Because from karaf 4.x there are both jetty 8 and jetty 9 feature existing. Making this changes will avoid install the wrong version jetty bundles when install camel-jetty (or camel-jetty8 of Camel 2.17.x)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)