camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10344) RouteIdFactory - That can assign route ids using derived values from uris
Date Tue, 01 Nov 2016 19:02:58 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626352#comment-15626352
] 

ASF GitHub Bot commented on CAMEL-10344:
----------------------------------------

GitHub user tkopczynski opened a pull request:

    https://github.com/apache/camel/pull/1242

    CAMEL-10344: RouteIdFactory - assigning route ids based on uris

    This PR adds RouteIdFactory which can be used as a NodeIdFactory implementation in CamelContext
as a different strategy for assigning route ids.
    
    Currently, it works with direct and similar routes.
    
    Unfortunately, I'm not sure on how to integrate this with assigning ids in rest routes.
It feels like this should be somewhere in `RestDefinition.addRouteDefinition` but route id
is assigned so early that RouteDefinition doesn't have enough information for creating the
id from the path.
    
    @davsclaus do you have any ideas/suggestions on this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tkopczynski/camel camel-10344

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1242
    
----
commit f0bc524b7546b398a4a4f804c63a7e0807d1b58a
Author: Tomasz Kopczynski <tomek@kopczynski.net.pl>
Date:   2016-11-01T18:49:06Z

    CAMEL-10344: RouteIdFactory - assigning route ids based on uris

----


> RouteIdFactory - That can assign route ids using derived values from uris
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-10344
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10344
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Priority: Minor
>             Fix For: Future
>
>
> When using routes that uses direct/seda etc as route inputs, then you may want to use
their name as the route id, eg
> direct:foo   -> foo
> seda:bar    -> bar
> jms:orders -> orders
> Instead of having route1, route2 as auto assigned names. 
> There could be a NodeIdFactory that assign such names for route's. For example it can
use the context-path of the route url as the name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message