camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10217) Remove logging implementations from compile scope
Date Fri, 05 Aug 2016 13:13:20 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409426#comment-15409426
] 

ASF GitHub Bot commented on CAMEL-10217:
----------------------------------------

GitHub user nicolaferraro opened a pull request:

    https://github.com/apache/camel/pull/1110

    CAMEL-10217: Removed logging implementation from compile scope in jbp…

    …m, jt400, scr, spark-rest

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nicolaferraro/camel CAMEL-10217

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1110
    
----
commit 2d9c0a177708a83756f70a230c8ae405df3f656d
Author: Nicola Ferraro <ni.ferraro@gmail.com>
Date:   2016-08-05T13:12:14Z

    CAMEL-10217: Removed logging implementation from compile scope in jbpm, jt400, scr, spark-rest

----


> Remove logging implementations from compile scope
> -------------------------------------------------
>
>                 Key: CAMEL-10217
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10217
>             Project: Camel
>          Issue Type: Bug
>            Reporter: Nicola Ferraro
>            Assignee: Nicola Ferraro
>            Priority: Trivial
>
> Some components include logging implementations among their dependencies. If it is applicable
(eg. if they are not hardcoded), they should be removed.
> A quick script:
> {code}
> for comp in $(ls | grep "camel-" | grep -v ".iml"); do
> 	cd $comp
> 	mvn dependency:tree | grep 'log4j\|logback\|slf4j-simple\|slf4j-jdk14\|slf4j-log4j12'
| grep -v test | xargs -I line echo "$(pwd) line"
> 	cd ..
> done
> {code}
> Shows the following problems:
> {noformat}
> ./camel/components/camel-atmos [INFO] |  +- log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-gora [INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.7.21:compile
> ./camel/components/camel-gora [INFO] |  - log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-hbase [INFO] |  +- log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-jbpm [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.21:compile
> ./camel/components/camel-jbpm [INFO] |  - log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-jt400 [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.21:compile
> ./camel/components/camel-jt400 [INFO] |  - log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-krati [INFO] |  - log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-openshift [INFO] |  - log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-salesforce [INFO] +- log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-scr [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.21:compile
> ./camel/components/camel-scr [INFO] +- log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-spark [INFO] |  +- log4j:log4j:jar:1.2.17:compile
> ./camel/components/camel-spark [INFO] |  |  +- log4j:apache-log4j-extras:jar:1.2.17:compile
> ./camel/components/camel-spark-rest [INFO] |  +- org.slf4j:slf4j-simple:jar:1.7.21:compile
> ./camel/components/camel-spring-boot [INFO] |  |  +- ch.qos.logback:logback-classic:jar:1.1.7:compile
> ./camel/components/camel-spring-boot [INFO] |  |  |  - ch.qos.logback:logback-core:jar:1.1.7:compile
> ./camel/components/camel-spring-boot [INFO] |  |  - org.slf4j:log4j-over-slf4j:jar:1.7.21:compile
> ./camel/components/camel-spring-boot-starter [INFO] |  |  +- ch.qos.logback:logback-classic:jar:1.1.7:compile
> ./camel/components/camel-spring-boot-starter [INFO] |  |  |  - ch.qos.logback:logback-core:jar:1.1.7:compile
> ./camel/components/camel-spring-boot-starter [INFO] |  |  - org.slf4j:log4j-over-slf4j:jar:1.7.21:compile
> ./camel/components/camel-zipkin-starter [INFO] |  |  +- ch.qos.logback:logback-classic:jar:1.1.7:compile
> ./camel/components/camel-zipkin-starter [INFO] |  |  |  - ch.qos.logback:logback-core:jar:1.1.7:compile
> ./camel/components/camel-zipkin-starter [INFO] |  |  - org.slf4j:log4j-over-slf4j:jar:1.7.21:compile
> ./camel/components/camel-zookeeper [INFO] |  +- log4j:log4j:jar:1.2.17:compile
> {noformat}
> Spring-boot starters are allowed to have logging implementations. _org.slf4j:log4j-over-slf4j_
is not an implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message