camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-9065) Exchange created needs to be aware of its FROM endpoint.
Date Sat, 27 Aug 2016 14:33:20 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441647#comment-15441647
] 

ASF GitHub Bot commented on CAMEL-9065:
---------------------------------------

Github user YoshikiHigo closed the pull request at:

    https://github.com/apache/camel/pull/1142


> Exchange created needs to be aware of its FROM endpoint. 
> ---------------------------------------------------------
>
>                 Key: CAMEL-9065
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9065
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-mongodb
>    Affects Versions: 2.15.2
>            Reporter: omar alles
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.16.0
>
>
> In 2.16, DefaultRuntimeEndpointRegistry (an EventNotifier) is extended to being able
to handle ExchangeCreatedEvent s. 
> In its notify(EventObjet), when processing an ExchangeCreateEvent, a reference to exchange's
from endpoint is needed in order to obtain its endpoint uri. 
> {code:title=DefaultRuntimeEndpointRegistry.java|borderStyle=solid}
> } else if (extended && event instanceof ExchangeCreatedEvent) {
>             // we only capture details in extended mode
>             ExchangeCreatedEvent ece = (ExchangeCreatedEvent) event;
>             Endpoint endpoint = ece.getExchange().getFromEndpoint();
>             String routeId = ece.getExchange().getFromRouteId();
>             String uri = endpoint.getEndpointUri();
>             String key = asUtilizationKey(routeId, uri);
>             if (key != null) {
>                 inputUtilization.onHit(key);
>             }
> {code}
> The problem is located in MongoDbEndpoint createMongoDbExchange)() 
> {code:title=MongoDbEndpoint.java|borderStyle=solid}
> public Exchange createMongoDbExchange(DBObject dbObj) {
>         Exchange exchange = new DefaultExchange(this.getCamelContext(), getExchangePattern());

>         ...
>     }
> {code}
> This Exchange constructor does not take into consideration exchange's from endpoint,
consequently causing a NPE when processing its associated ExchangeCreatedEvent.
> When constructing an exchange,  MongoDbEndpoint should use its parent 's createExchange()
which uses the proper Exchange constructors. 
> {code:title=MongoDbEndpoint.java|borderStyle=solid}
> public Exchange createMongoDbExchange(DBObject dbObj) {
> //        Exchange exchange = new DefaultExchange(this.getCamelContext(), getExchangePattern());
>         Exchange exchange = super.createExchange();
> ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message