Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 792EC200B5A for ; Wed, 20 Jul 2016 18:02:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7768C160A64; Wed, 20 Jul 2016 16:02:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0D9B160A86 for ; Wed, 20 Jul 2016 18:02:21 +0200 (CEST) Received: (qmail 85974 invoked by uid 500); 20 Jul 2016 16:02:20 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 85937 invoked by uid 99); 20 Jul 2016 16:02:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2016 16:02:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A9FBB2C0E09 for ; Wed, 20 Jul 2016 16:02:20 +0000 (UTC) Date: Wed, 20 Jul 2016 16:02:20 +0000 (UTC) From: "Matthew Zipay (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CAMEL-10038) BlueprintPropertiesParser breaks propertyPlaceholder fallbackToUnaugmentedProperty behavior MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 20 Jul 2016 16:02:22 -0000 [ https://issues.apache.org/jira/browse/CAMEL-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386090#comment-15386090 ] Matthew Zipay commented on CAMEL-10038: --------------------------------------- [~davsclaus] and [~gzres], the pull request now includes a unit test for the fallbackToUnaugmentedProperty relative to BlueprintPropertiesParser. Both org.apache.camel.test.blueprint.ConfigAdminNoDefaultValuesBlueprintCreationTest and the new org.apache.camel.test.blueprint.BlueprintAugmentedPropertiesFallbackTest test cases are now passing on 2.18-SNAPSHOT. > BlueprintPropertiesParser breaks propertyPlaceholder fallbackToUnaugmentedProperty behavior > ------------------------------------------------------------------------------------------- > > Key: CAMEL-10038 > URL: https://issues.apache.org/jira/browse/CAMEL-10038 > Project: Camel > Issue Type: Bug > Components: camel-blueprint > Affects Versions: 2.15.1 > Environment: Camel 2.15.1.redhat-620133 > JBoss Fuse 6.2.0.redhat-133 > openjdk version "1.8.0_45" > OpenJDK Runtime Environment (build 1.8.0_45-b13) > OpenJDK 64-Bit Server VM (build 25.45-b02, mixed mode) > Linux 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 6 17:12:08 EST 2015 x86_64 GNU/Linux (RHEL 7) > Reporter: Matthew Zipay > Assignee: Grzegorz Grzybek > Priority: Minor > Labels: patch > Attachments: CAMEL-10038.patch, camel-context.xml, example.bpp.fallback.cfg > > > When BlueprintPropertiesParser parses an "augmented" property key that is not found (i.e. value is null), it does not return the null value so that the fallbackToUnaugmentedProperty="true" (default) behavior can run. Instead, it immediately throws an IllegalArgumentException. > As a result, it appears to be impossible to take advantage of fallbackToUnaugmentedProperty="true" behavior when using the Blueprint properties resolver/parser. > I discovered this against Red Hat's JBoss Fuse impl of Camel, but am reporting it here because it appears to be a bug in base Camel. More details in comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)