camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-10121) ResponsHandler in Mina2Producer should not log errors
Date Tue, 05 Jul 2016 18:58:11 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363016#comment-15363016
] 

ASF GitHub Bot commented on CAMEL-10121:
----------------------------------------

GitHub user gijsbert802 opened a pull request:

    https://github.com/apache/camel/pull/1064

    CAMEL-10121: don't log error when an exception is caught in the ResponseHandler

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gijsbert802/camel CAMEL-10121

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/1064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1064
    
----
commit 31f1b2cbdcc8e02924fde2a0bc30f8da01248302
Author: Gijsbert van den Brink <vandenbrink@zorgdomein.nl>
Date:   2016-07-05T18:53:09Z

    CAMEL-10121: don't log error when an exception is caught in the ResponseHandler

----


> ResponsHandler in Mina2Producer should not log errors
> -----------------------------------------------------
>
>                 Key: CAMEL-10121
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10121
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-mina2
>            Reporter: Gijsbert van den Brink
>            Priority: Minor
>
> When an exception occurs in the ResponseHandler an error is logged AND the exception
is then wrapped in a CamelExchangeException and re-thrown.
> So if I choose to handle certain exceptions in my route I still get an error in the logs.
> As long as Mina2Producer throws these exceptions there's no need to log an error (or
anything actually) in my opinion. 
> Do you agree that the "LOG.error("Exception on receiving message from address ..." line
can be removed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message