camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <>
Subject [jira] [Commented] (CAMEL-9954) FormatFactory should be real Factory-pattern
Date Sat, 21 May 2016 06:36:13 GMT


Claus Ibsen commented on CAMEL-9954:

Arno would you mind using github and do your patches as PR instead. Doing these big patch
files manually is a pain and more error prone. Especially when files are deleted / moved and

You just do regular PRs at github from

eg you can fork the project, create a branch, and work on that branch, and then commit and
push. And then if you browse to

then githuib in the top of the page, has a "do you want to submit a PR from your branch to
..." dialog.

> FormatFactory should be real Factory-pattern
> --------------------------------------------
>                 Key: CAMEL-9954
>                 URL:
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>            Reporter: Arno Noordover
>            Priority: Minor
>             Fix For: 2.18.0
>         Attachments: CAMEL_9954Patch2.patch, CAMEL_9954__FormatFactory_should_be_real_Factory_pattern.patch
>   Original Estimate: 48h
>  Remaining Estimate: 48h
> The class org.apache.camel.dataformat.bindy.FormatFactory is a utility class which supports
a factory-pattern.
> According to the factory-pattern this should not be a utility-class but it should be
a class that can be instantiated.
> This class should implement an interface or extend an abstract class.
> Maybe we should make a factory per Format and choose amongst the following solutions:
> * let each formatter answer the question about being able to format for certain formating-options
(based on type and optionally the pattern for all "numeric" format factories);
> * put all formatters in a hashmap with the type as a key.
> With this last solution all the "numeric" format factory should decide which format to
return (e.g. BytePatternFormat or ByteFormat based on the pattern being empty or not)

This message was sent by Atlassian JIRA

View raw message