Return-Path: X-Original-To: apmail-camel-issues-archive@minotaur.apache.org Delivered-To: apmail-camel-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89B9B19C9D for ; Wed, 16 Mar 2016 06:34:34 +0000 (UTC) Received: (qmail 4422 invoked by uid 500); 16 Mar 2016 06:34:34 -0000 Delivered-To: apmail-camel-issues-archive@camel.apache.org Received: (qmail 4298 invoked by uid 500); 16 Mar 2016 06:34:34 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 4033 invoked by uid 99); 16 Mar 2016 06:34:34 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 06:34:34 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BC1A42C1F68 for ; Wed, 16 Mar 2016 06:34:33 +0000 (UTC) Date: Wed, 16 Mar 2016 06:34:33 +0000 (UTC) From: "Claus Ibsen (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CAMEL-9708) Multiple tests not using equality predicate correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAMEL-9708?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1519= 6864#comment-15196864 ]=20 Claus Ibsen commented on CAMEL-9708: ------------------------------------ I wonder if this has causes some of these tests to fail {code} org.apache.camel.component.boon.BoonDataFormatTest.testMarshalAndUnmarshalM= ap org.apache.camel.component.boon.BoonDataFormatTest.testMarshalAndUnmarshalP= ojoMap org.apache.camel.component.gson.GsonMarshalExclusionTest.testMarshalAndUnma= rshalPojoWithExclusion org.apache.camel.component.gson.GsonMarshalExclusionTest.testMarshalAndUnma= rshalPojoWithAnotherExclusion org.apache.camel.component.jackson.JacksonJAXBAnnotationTest.testMarshalJAX= BObject org.apache.camel.component.jackson.JacksonMarshalViewTest.testMarshalAndUnm= arshalPojoWithAnotherView org.apache.camel.component.jackson.JacksonMarshalViewTest.testMarshalAndUnm= arshalPojoWithView org.apache.camel.component.jackson.SpringJacksonJsonDataFormatTest.testMars= halAndUnmarshalAgeView org.apache.camel.component.jacksonxml.JacksonJAXBAnnotationTest.testMarshal= JAXBObject org.apache.camel.component.jacksonxml.JacksonMarshalViewTest.testMarshalAnd= UnmarshalPojoWithAnotherView org.apache.camel.component.jacksonxml.JacksonMarshalViewTest.testMarshalAnd= UnmarshalPojoWithView org.apache.camel.component.jacksonxml.SpringJacksonJsonDataFormatTest.testM= arshalAndUnmarshalAgeView {code} The CI server reported those https://builds.apache.org/job/Camel.trunk.fulltest.java8/687/#showFailuresL= ink It could be before the test was correct or wrong but passed anyway. > Multiple tests not using equality predicate correctly > ----------------------------------------------------- > > Key: CAMEL-9708 > URL: https://issues.apache.org/jira/browse/CAMEL-9708 > Project: Camel > Issue Type: Test > Components: tests > Reporter: Jaros=C5=82aw Strzelecki > Assignee: Claus Ibsen > Priority: Minor > Fix For: 2.17.0 > > > There are multiple test having similar 'assertion' that do not verify equ= ality: > {quote} > mockEndpoint.message(0).body().equals(body); > {quote} > The correct syntax would be: > {quote} > mockEndpoint.message(0).body().isEqualTo(body); > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)