camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-9391) Set parameter enableEventsResending should be before Atmosphere wrap request
Date Sat, 05 Dec 2015 13:34:11 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-9391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043313#comment-15043313
] 

ASF GitHub Bot commented on CAMEL-9391:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/camel/pull/710


> Set parameter enableEventsResending should be before Atmosphere wrap request
> ----------------------------------------------------------------------------
>
>                 Key: CAMEL-9391
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9391
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-atmosphere-websocket
>            Reporter: Pavlo Kletsko
>              Labels: patch
>             Fix For: 2.17.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This is a defect regarding CAMEL-9364 feature.
> WebsocketConsumer has service method where Atmosphere handle incoming request. In case
value for enableEventsResending will be set after request is handled OnOpen event will not
be sent at all. 
> Consequently, set this value should be before such as :
>         this.enableEventsResending = enableEventsResending;
>         framework.doCometSupport(AtmosphereRequest.wrap(request), AtmosphereResponse.wrap(response));
> In addition to this because of CamelWebSocketServlet use init method for set enableEventsResending
value,  tests which were written for this feature are wrong. To solve this a new TestSupport
class should be created where init parameter will be set correctly and tests depending on
this parameter will be moved to separate class which extend the new TestSupport class. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message