camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ramon Rosa da Silva (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CAMEL-8302) Rabbitmq shouldn't require/bind queue if not specified
Date Tue, 03 Nov 2015 16:13:27 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987527#comment-14987527
] 

Ramon Rosa da Silva edited comment on CAMEL-8302 at 11/3/15 4:13 PM:
---------------------------------------------------------------------

Already exists verify to declare a queue:

{code:title=RabbitMQEndpoint.java|borderStyle=solid}
if (getQueue() != null) {
  channel.queueDeclare(getQueue(), isDurable(), false, isAutoDelete(), queueArgs);
{code}
But the queue never is null, because it is initialized:
{code:title=RabbitMQEndpoint.java|borderStyle=solid}
@UriParam
private String queue = String.valueOf(UUID.randomUUID().toString().hashCode());
{code}

I think initialize the queue with "null" resolves this issue.


was (Author: neoramon):
Already exists verify to declare a queue:

{code:title=RabbitMQEndpoint.java|borderStyle=solid}
if (getQueue() != null) {
  channel.queueDeclare(getQueue(), isDurable(), false, isAutoDelete(), queueArgs);
{code}
But the queue never is null, because it is initialized:
{code:title=RabbitMQEndpoint.java|borderStyle=solid}
@UriParam
private String queue = String.valueOf(UUID.randomUUID().toString().hashCode());
{code}

I think that initialize queue with null resolve this issue.

> Rabbitmq shouldn't require/bind queue if not specified 
> -------------------------------------------------------
>
>                 Key: CAMEL-8302
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8302
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-rabbitmq
>    Affects Versions: 2.14.1
>            Reporter: Sajjad Akhter
>             Fix For: Future
>
>
> Current implementation is declaring both exchange and queue on any init (producer or
consumer). In case of producer one don't need queue and may not know who going to be client.

> We can add flag skipQueueDeclare  so that it won't genrate uuid queue. 
> i can provide PR if it helps. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message