camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-9023) Use Redis String instead of Set as datatype for idempotent consumer
Date Thu, 24 Sep 2015 14:58:04 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906457#comment-14906457
] 

ASF GitHub Bot commented on CAMEL-9023:
---------------------------------------

GitHub user mzapletal opened a pull request:

    https://github.com/apache/camel/pull/619

    ADDED Redis String based idempotent repository to support expiration,…

    … refs https://issues.apache.org/jira/browse/CAMEL-9023
    
    First version of an idempotent repository based on the Redis String data type. Test is
still missing - I guess it doesn't make much sense to provide another unit test mocking Redis,
but I can add an integration test if desired.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mzapletal/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #619
    
----
commit 490c5b6ee8646822ce50f41b7683be22a0d54f2c
Author: Marco Zapletal <marco@edistream.com>
Date:   2015-09-24T14:52:16Z

    ADDED Redis String based idempotent repository to support expiration, refs https://issues.apache.org/jira/browse/CAMEL-9023

----


> Use Redis String instead of Set as datatype for idempotent consumer
> -------------------------------------------------------------------
>
>                 Key: CAMEL-9023
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9023
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-spring-redis
>    Affects Versions: 2.15.2
>            Reporter: Marco Zapletal
>            Priority: Minor
>             Fix For: Future
>
>
> The current implementation of the RedisIdempotentRepository uses a (Redis) set as the
underlying data structure. This is conceptually nice for keeping all consumed keys in a single
logical location. However, it makes the management of keys more difficult, since we cannot
use Redis' built in mechanisms for expiring keys and have to do a manual cleanup.
> Thus, this issue proposes to use Redis String as the datatype for a single entry in order
to provide support for expiring keys. If the community is in favor of this idea, I am happy
to provide a patch (or a second, alternative implementation).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message