camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Serge Smertin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CAMEL-9101) RabbitMQ specific message properties are forwarded as message headers
Date Tue, 25 Aug 2015 11:33:45 GMT

     [ https://issues.apache.org/jira/browse/CAMEL-9101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Serge Smertin updated CAMEL-9101:
---------------------------------
    Description: 
org.apache.camel.component.rabbitmq.RabbitMQProducer#buildProperties does not remove message
headers from exchange after property is set, leading to message header pollution.

so constructs like 

{code}
final Object contentType = exchange.getIn().getHeader(RabbitMQConstants.CONTENT_TYPE);
        if (contentType != null) {
            properties.contentType(contentType.toString());
        }
{code}

must be rewritten as

{code}
final Object contentType = exchange.getIn().removeHeader(RabbitMQConstants.CONTENT_TYPE);
        if (contentType != null) {
            properties.contentType(contentType.toString());
        }
{code}

I don't think that these are used in business logic as this is solely transport specific.

  was:
org.apache.camel.component.rabbitmq.RabbitMQProducer#buildProperties does not remove message
headers from exchange after property is set, leading to message header pollution.

so constructs like 

````
final Object contentType = exchange.getIn().getHeader(RabbitMQConstants.CONTENT_TYPE);
        if (contentType != null) {
            properties.contentType(contentType.toString());
        }
````

must be rewritten as

````
final Object contentType = exchange.getIn().removeHeader(RabbitMQConstants.CONTENT_TYPE);
        if (contentType != null) {
            properties.contentType(contentType.toString());
        }
````

I don't think that these are used in business logic as this is solely transport specific.


> RabbitMQ specific message properties are forwarded as message headers
> ---------------------------------------------------------------------
>
>                 Key: CAMEL-9101
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9101
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-rabbitmq
>    Affects Versions: 2.15.2
>            Reporter: Serge Smertin
>
> org.apache.camel.component.rabbitmq.RabbitMQProducer#buildProperties does not remove
message headers from exchange after property is set, leading to message header pollution.
> so constructs like 
> {code}
> final Object contentType = exchange.getIn().getHeader(RabbitMQConstants.CONTENT_TYPE);
>         if (contentType != null) {
>             properties.contentType(contentType.toString());
>         }
> {code}
> must be rewritten as
> {code}
> final Object contentType = exchange.getIn().removeHeader(RabbitMQConstants.CONTENT_TYPE);
>         if (contentType != null) {
>             properties.contentType(contentType.toString());
>         }
> {code}
> I don't think that these are used in business logic as this is solely transport specific.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message