camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David J. M. Karlsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-8293) Be more override-friendly in CamelTestSupport by returning interface type instead of concrete impl
Date Mon, 02 Feb 2015 10:12:35 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301108#comment-14301108
] 

David J. M. Karlsen commented on CAMEL-8293:
--------------------------------------------

It ran ok (mvn clean install -Pspring4 >& /tmp/build.log&) until a test which fails
due to something else:

Test set: org.apache.camel.spring.processor.aggregator.SpringAggregateGroupedExchangeCompletionExpressionSizeTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.016 sec <<< FAILURE!
- in org.apache.camel.spring.processor.aggregator.SpringAggregateGroupedExchangeCompletionExpressionSizeTest
testGrouped(org.apache.camel.spring.processor.aggregator.SpringAggregateGroupedExchangeCompletionExpressionSizeTest)
 Time elapsed: 0.015 sec  <<< ERROR!
org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line 28 in XML document
from class path resource [org/apache/camel/spring/processor/aggregator/SpringAggregateGroupedExchangeCompletionExpressionSizeTest.xml]
is invalid; nested exception is org.xml.sax.SAXParseException; lineNumber: 28; columnNumber:
46; cvc-complex-type.4: Attribute 'strategyRef' must appear on element 'aggregate'.
        at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
 

Trying to rerun with -Dmaven.test.failure.ignore=true

> Be more override-friendly in CamelTestSupport by returning interface type instead of
concrete impl
> --------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-8293
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8293
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-test
>    Affects Versions: 2.14.1
>            Reporter: David J. M. Karlsen
>
> CamelTestSupport has a 
> protected JndiRegistry createRegistry()
> method.
> It would be better if it returned the Generic type Registry instead - that way you can
override the method and return a SimpleRegistry for your tests without having to do this in
createCamelContext() which defats createRegistry's purpose.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message