camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-8293) Be more override-friendly in CamelTestSupport by returning interface type instead of concrete impl
Date Wed, 28 Jan 2015 21:58:34 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295932#comment-14295932
] 

ASF GitHub Bot commented on CAMEL-8293:
---------------------------------------

GitHub user davidkarlsen opened a pull request:

    https://github.com/apache/camel/pull/383

    CAMEL-8293: Be more override-friendly in CamelTestSupport by returning i...

    ...nterface type instead of concrete impl

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davidkarlsen/camel CAMEL-8293

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #383
    
----
commit b894b4a79058ef4dd456e3fd6204a373cbcae228
Author: david <david@davidkarlsen.com>
Date:   2015-01-28T21:56:58Z

    CAMEL-8293: Be more override-friendly in CamelTestSupport by returning interface type
instead of concrete impl

----


> Be more override-friendly in CamelTestSupport by returning interface type instead of
concrete impl
> --------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-8293
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8293
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-test
>    Affects Versions: 2.14.1
>            Reporter: David J. M. Karlsen
>
> CamelTestSupport has a 
> protected JndiRegistry createRegistry()
> method.
> It would be better if it returned the Generic type Registry instead - that way you can
override the method and return a SimpleRegistry for your tests without having to do this in
createCamelContext() which defats createRegistry's purpose.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message