Return-Path: X-Original-To: apmail-camel-issues-archive@minotaur.apache.org Delivered-To: apmail-camel-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E55F109A1 for ; Wed, 3 Dec 2014 22:24:18 +0000 (UTC) Received: (qmail 33691 invoked by uid 500); 3 Dec 2014 22:24:12 -0000 Delivered-To: apmail-camel-issues-archive@camel.apache.org Received: (qmail 33539 invoked by uid 500); 3 Dec 2014 22:24:12 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 33302 invoked by uid 99); 3 Dec 2014 22:24:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Dec 2014 22:24:12 +0000 Date: Wed, 3 Dec 2014 22:24:12 +0000 (UTC) From: "Mark Mindenhall (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CAMEL-8120) ChannelHandlerFactories.newDelimiterBasedFrameDecoder always strips delimiters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Mark Mindenhall created CAMEL-8120: -------------------------------------- Summary: ChannelHandlerFactories.newDelimiterBasedFrameDecoder always strips delimiters Key: CAMEL-8120 URL: https://issues.apache.org/jira/browse/CAMEL-8120 Project: Camel Issue Type: Bug Components: camel-netty4 Affects Versions: 2.14.0 Reporter: Mark Mindenhall The constructor of _{{io.netty.handler.codec.DelimiterBasedFrameDecoder}}_ includes a boolean _{{stripDelimiter}}_ parameter, which is always set to true by the _{{ChannelHandlerFactories.newDelimiterBasedFrameDecoder}}_ method (both directly and within _{{org.apache.camel.component.netty4.codec.DatagramPacketDelimiterDecoder}}_, which delegates to _{{DelimiterBasedFrameDecoder}}_) This parameter needs to be set to false when the end-of-frame delimiter is part of the message (e.g., the closing tag of an XML document), and therefore must not be discarded. Suggested fix: - Add a new constructor to _{{DatagramPacketDelimiterDecoder}}_ that includes the parameter, which is then passed through to the delegate _{{DelimiterBasedFrameDecoder}}_ - Add a new method signature for _{{ChannelHandlerFactories.newDelimiterBasedFrameDecoder}}_ that includes the parameter - refactor existing _{{newDelimiterBasedFrameDecoder}}_ method to delegate to the new method -- This message was sent by Atlassian JIRA (v6.3.4#6332)