camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Anstey (JIRA)" <>
Subject [jira] [Resolved] (CAMEL-7627) Quartz/Quartz2 in cluster mode doesn't apply changed trigger settings
Date Thu, 13 Nov 2014 15:23:34 GMT


Jonathan Anstey resolved CAMEL-7627.
       Resolution: Fixed
    Fix Version/s: 2.13.4
         Assignee: Jonathan Anstey

Just merged your patches with a few miro modifications. Thanks Nikolay!

> Quartz/Quartz2 in cluster mode doesn't apply changed trigger settings
> ---------------------------------------------------------------------
>                 Key: CAMEL-7627
>                 URL:
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-quartz, camel-quartz2
>            Reporter: Nikolay Turpitko
>            Assignee: Jonathan Anstey
>             Fix For: 2.14.1, 2.15.0, 2.13.4
>         Attachments: 0001-Fix-reshedule-changed-trigger-after-restart.patch, 0002-Test-trigger-type-change.patch
> Camel-quartz2 component in clustered mode uses trigger options stored in DB rather (possibly
changed) ones from endpoint's URI.
> Desirable behavior is to compare trigger options in DB and endpoint's URI and reschedule
quartz job when they changed (like in camel-quartz component).
> Component camel-quartz already have this functionality, but there is no test for it and
it works incorrectly with changed SimpleTrigger options.
> I attached a patch with unit tests. Every test prepares DB, than creates application
context twice with different trigger options. Both times it retrieves options back, accessing
them via trigger (not via endpoint, so that it uses values stored in DB). After that it asserts
that retrieved options are indeed different.
> You can ensure, that the tests fail with old versions of org.apache.camel.component.quartz2.QuartzEndpoint#addJobInScheduler
or org.apache.camel.component.quartz.QuartzComponent#hasTriggerChanged methods and pass with
patched implementation.

This message was sent by Atlassian JIRA

View raw message