camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Willem Jiang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CAMEL-6819) Use exceptionHandler on Xmpp Consumer
Date Wed, 14 May 2014 02:00:18 GMT

     [ https://issues.apache.org/jira/browse/CAMEL-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Willem Jiang resolved CAMEL-6819.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.14.0

Applied the patch with thanks to Andrea and I also added a check to avoid the NPE of exceptionHandler.

> Use exceptionHandler on Xmpp Consumer
> -------------------------------------
>
>                 Key: CAMEL-6819
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6819
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-xmpp
>    Affects Versions: 2.12.1
>         Environment: all
>            Reporter: bounkong khamphousone
>            Assignee: Willem Jiang
>            Priority: Minor
>             Fix For: 2.14.0
>
>
> Hi!
> What do you think about adding a call to the exceptionHandler in the doStart() method
of XmppConsumer class ?
> It would looks like : 
> try {
>             connection = endpoint.createConnection();
>         } catch (XMPPException e) {
>             if (endpoint.isTestConnectionOnStartup()) {
>                 throw new RuntimeException("Could not connect to XMPP server.", e);
>             }  else {
>             	final String xmppExceptionLogMessage = XmppEndpoint.getXmppExceptionLogMessage(e);
>                 LOG.warn(xmppExceptionLogMessage);
>                 getExceptionHandler().handleException(xmppExceptionLogMessage,e);
>                 scheduleDelayedStart();
>                 return;
>             }
>         }
> This allowed an exceptionHandler to be notified of failure connection.
> The testConnectionOnStartup doesn't call exceptionHandler because the exception is thrown
while starting the consumer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message