camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-6819) Use exceptionHandler on Xmpp Consumer
Date Tue, 13 May 2014 20:31:22 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996864#comment-13996864
] 

ASF GitHub Bot commented on CAMEL-6819:
---------------------------------------

Github user ancosen closed the pull request at:

    https://github.com/apache/camel/pull/150


> Use exceptionHandler on Xmpp Consumer
> -------------------------------------
>
>                 Key: CAMEL-6819
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6819
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-xmpp
>    Affects Versions: 2.12.1
>         Environment: all
>            Reporter: bounkong khamphousone
>            Priority: Minor
>
> Hi!
> What do you think about adding a call to the exceptionHandler in the doStart() method
of XmppConsumer class ?
> It would looks like : 
> try {
>             connection = endpoint.createConnection();
>         } catch (XMPPException e) {
>             if (endpoint.isTestConnectionOnStartup()) {
>                 throw new RuntimeException("Could not connect to XMPP server.", e);
>             }  else {
>             	final String xmppExceptionLogMessage = XmppEndpoint.getXmppExceptionLogMessage(e);
>                 LOG.warn(xmppExceptionLogMessage);
>                 getExceptionHandler().handleException(xmppExceptionLogMessage,e);
>                 scheduleDelayedStart();
>                 return;
>             }
>         }
> This allowed an exceptionHandler to be notified of failure connection.
> The testConnectionOnStartup doesn't call exceptionHandler because the exception is thrown
while starting the consumer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message