camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Pocock (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-7225) camel-smpp - should check Exchange.CHARSET_NAME header
Date Sun, 27 Apr 2014 10:14:14 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982286#comment-13982286
] 

Daniel Pocock commented on CAMEL-7225:
--------------------------------------

Another thing I notice, the original code checks

Charset.isSupported(configuration.getEncoding())

on every message.  The patch is only doing that for encodings from the header.

Maybe it should check the default configured encoding in the initialization of the component
and throw an exception there if somebody tries to configure with an invalid encoding?


> camel-smpp - should check Exchange.CHARSET_NAME header
> ------------------------------------------------------
>
>                 Key: CAMEL-7225
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7225
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-smpp
>    Affects Versions: 2.12.2
>         Environment: any
>            Reporter: Daniel Pocock
>            Priority: Minor
>             Fix For: Future
>
>
> The camel-smpp component should check the Exchange.CHARSET_NAME header of each message
to determine the actual encoding of byte[] messages
> It appears that it currently expects all byte[] messages to be encoded in the character
set specified by the "encoding" property on the endpoint



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message