camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CAMEL-7155) Incorrect implementation of the method StringHelper.hasStartToken()
Date Thu, 06 Feb 2014 09:54:13 GMT

     [ https://issues.apache.org/jira/browse/CAMEL-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Claus Ibsen updated CAMEL-7155:
-------------------------------

    Fix Version/s: 2.13.0

> Incorrect implementation of the method StringHelper.hasStartToken()
> -------------------------------------------------------------------
>
>                 Key: CAMEL-7155
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7155
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.12.2
>            Reporter: Tomas Rohovsky
>            Priority: Minor
>             Fix For: 2.13.0
>
>
> From the semantic point of view the method hasStartToken() should return false in case
of an expression without language specified, i.e. starting with "${". 
> However, it is correct to return true in current usage of hasStartToken() in camel-core,
i.e. checking if an expression is in simple language, since if the expression does not contain
the language token, then it is a simple expression.
> The method calls for checking of simple language should be replaced with a newly created
method isSimpleLanguage(String expression) that would check if the language is a simple expression,
i.e. hasStartToken(expression, "simple") || expression.indexOf("${") >= 0.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message