Return-Path: X-Original-To: apmail-camel-issues-archive@minotaur.apache.org Delivered-To: apmail-camel-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 107451067C for ; Sun, 10 Nov 2013 13:12:20 +0000 (UTC) Received: (qmail 43144 invoked by uid 500); 10 Nov 2013 13:12:19 -0000 Delivered-To: apmail-camel-issues-archive@camel.apache.org Received: (qmail 43078 invoked by uid 500); 10 Nov 2013 13:12:17 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 43070 invoked by uid 99); 10 Nov 2013 13:12:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Nov 2013 13:12:17 +0000 Date: Sun, 10 Nov 2013 13:12:17 +0000 (UTC) From: "Babak Vahdat (JIRA)" To: issues@camel.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (CAMEL-6951) camel-core - Improve ServiceHelper utility class. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAMEL-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Babak Vahdat resolved CAMEL-6951. --------------------------------- Resolution: Fixed > camel-core - Improve ServiceHelper utility class. > ------------------------------------------------- > > Key: CAMEL-6951 > URL: https://issues.apache.org/jira/browse/CAMEL-6951 > Project: Camel > Issue Type: Improvement > Components: camel-core > Affects Versions: 2.12.1 > Reporter: Babak Vahdat > Assignee: Babak Vahdat > Priority: Minor > Fix For: 2.11.3, 2.12.2, 2.13.0 > > > There're bunch of minor flaws by the {{ServiceHelper}} utility class such as: > - The {{stopAndShutdownServices(Collection services)}} method has a minor bug in that it does *not* stop each given service inside the {{try/catch}} block. Potentially this would cause us to *miss* stopping/shutting down the remaining elements of the given {{services}} in case stopping of one the service objects would throw an exception! > - The utility {{startServices(Object... services)}} has got code-duplication! Instead it should reuse {{startServices(Collection services)}} > - Lack of Javadoc by bunch of it's utility methods. > - Some existing Javadoc is not really clear & precise about what the method exactly/really does. -- This message was sent by Atlassian JIRA (v6.1#6144)