camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CAMEL-6716) ServiceInterfaceStrategy fails to create with interface containing multiple methods without parameters
Date Wed, 20 Nov 2013 07:35:25 GMT

     [ https://issues.apache.org/jira/browse/CAMEL-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Claus Ibsen updated CAMEL-6716:
-------------------------------

    Fix Version/s:     (was: 2.12.2)
                   2.12.3

> ServiceInterfaceStrategy fails to create with interface containing multiple methods without
parameters
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-6716
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6716
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-soap
>    Affects Versions: 2.12.0
>            Reporter: Ondrej Fischer
>            Priority: Minor
>             Fix For: 2.13.0, 2.12.3
>
>
> I you attempt to create a ServiceInterfaceStrategy with interface containing multiple
methods without parameters, you get NullPointerException.
> It's due to following code:
> ServiceInterfaceStrategy.java:161
> {code}
> 155    private void analyzeServiceInterface(Class<?> serviceInterface) {
> 156        Method[] methods = serviceInterface.getMethods();
> 157        for (Method method : methods) {
> 158            MethodInfo info = analyzeMethod(method);
> 159            for (int i = 0; i < info.getIn().length; i++) {
> 160                TypeInfo ti = info.getIn()[i];
> 161                if (inTypeNameToQName.containsKey(ti.getTypeName())
> 162                    && (!(ti.getTypeName().equals("javax.xml.ws.Holder")))
> 163                    && (!(inTypeNameToQName.get(ti.getTypeName()).equals(ti.getElName()))))
{
> 164                    LOG.warn("Ambiguous QName mapping. The type [ "
> 165                                                    + ti.getTypeName()
> 166                                                    + " ] is already mapped to a QName
in this context.");
> 167                    continue;
> 168                }
> 169                inTypeNameToQName.put(ti.getTypeName(), ti.getElName());
> 170            }
> 171            if (info.getSoapAction() != null && !"".equals172(info.getSoapAction()))
{
> 172                soapActionToMethodInfo.put(info.getSoapAction(), info);
> 173            }
> 174
> 175            outTypeNameToQName.put(info.getOut().getTypeName(), info.getOut().getElName());
> 176
> 177            addExceptions(method);
> 178        }
> 179    }
> {code}
> For the second method without parameters, the null value is already in the inTypeNameToQName,
so it tries to evaluate this: !(ti.getTypeName().equals("javax.xml.ws.Holder"), which fails
with NPE.
> The question here is, why method without parameters still needs an array of types containing
one element with those null values.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message