camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CAMEL-6734) Introduce CamelConsumedFileName Header
Date Thu, 12 Sep 2013 07:24:54 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765238#comment-13765238
] 

Claus Ibsen edited comment on CAMEL-6734 at 9/12/13 7:24 AM:
-------------------------------------------------------------

There were a couple of checkstyle issues which I will fix

You can read about how to build with CS
http://camel.apache.org/building.html

This would be good to check before submitting a patch, to ensure the code formatting is consistent
and valid


davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Camel :: Core 2.13-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core ---
[INFO]
[INFO] --- maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core ---
[INFO] Starting audit...
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23:
Wrong order for 'java.io.File' import.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68:
')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72:
')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72:
')' is preceded with whitespace.
Audit done.

                
      was (Author: davsclaus):
    There were a couple of checkstyle issues which I will fix

You can read about how to build with CS
http://camel.apache.org/building.html

This would be good to check before submitting a patch, to ensure the code formatting is consistent
and valid


davsclaus:~/workspace/camel/camel-core$ mvn compile -Psourcecheck
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Camel :: Core 2.13-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-bundle-plugin:2.3.7:cleanVersions (versions) @ camel-core ---
[INFO]
[INFO] --- maven-checkstyle-plugin:2.9.1:checkstyle (validate) @ camel-core ---
[INFO] Starting audit...
/Users/davsclaus/workspace/camel/camel-core/src/main/java/org/apache/camel/model/dataformat/TidyMarkupDataFormat.java:26:
Wrong order for 'org.w3c.dom.Node' import.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:23:
Wrong order for 'java.io.File' import.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:41:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:42:68:
')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:49:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:50:72:
')' is preceded with whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:20:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:58:57:
',' is not followed by whitespace.
/Users/davsclaus/workspace/camel/camel-core/src/test/java/org/apache/camel/component/file/FileProducerConsumedFileNameEvaluationTest.java:59:72:
')' is preceded with whitespace.
Audit done.

                  
> Introduce CamelConsumedFileName Header
> --------------------------------------
>
>                 Key: CAMEL-6734
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6734
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: James Carman
>            Assignee: Claus Ibsen
>             Fix For: 2.10.7, 2.11.2, 2.12.1, 2.13.0
>
>         Attachments: CAMEL-6734.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> On the producing side, we have CamelProducedFileName.  It would be nice if we had access
to the original consumed file name in a similar fashion.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message