Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Fri, 5 Jul 2013 14:11:48 +0000 (UTC)
From: "Joerg Kessler (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.12656379.1373033403475.3972.1373033508200@arcas>
In-Reply-To: <JIRA.12656379.1373033403475@arcas>
References: <JIRA.12656379.1373033403475@arcas>
Subject: [jira] [Created] (CAMEL-6514) SFTP: NPE if no private key file is
 supplied
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Joerg Kessler created CAMEL-6514:
------------------------------------

             Summary: SFTP: NPE if no private key file is supplied
                 Key: CAMEL-6514
                 URL: https://issues.apache.org/jira/browse/CAMEL-6514
             Project: Camel
          Issue Type: Bug
          Components: camel-ftp
    Affects Versions: 2.10.4
            Reporter: Joerg Kessler
            Priority: Minor


Hi,
a NPE is thrown if no private key file is supplied in the configuration for=
 SFTP. The error is
Caused by: java.lang.NullPointerException: while trying to get the length o=
f an array loaded from local variable 'foo'
at com.jcraft.jsch.Buffer.putString(Buffer.java:59)
I have analysed the code a bit and found that the problem is caused
by the class SftpOperations. The method createSession sets the userInfo for=
 the seesion by an inline class. Here the method promptKeyboardInteractive =
does not work correctly if no private key file is supplied. In that case JS=
CH switches to user/pw authorization and this method is called. But since t=
here is no password maintained the configation object returns NULL. The pre=
sent implementation adds it to the string array causing the error in JSCH. =
JSCH either wants a NULL string array or an empty string array (I have test=
ed both). So the code should look e.g. as follows:

            public String[] promptKeyboardInteractive(String destination, S=
tring name, String instruction, String[] prompt, boolean[] echo) {
                String password =3D configuration.getPassword();
                if (password =3D=3D null) {
                    return new String[0];
                } else {
                    return new String[] { password };
                }
            }
With that change JSCH returns
Caused by: java.io.FileNotFoundException: ./data/ssh/id_rsa (No such file o=
r directory)
=09at java.io.FileInputStream.open(Native Method)

and that is the real cause of the error=20

Best Regards,

J=C3=B6rg=20


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira