Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Wed, 24 Jul 2013 21:17:49 +0000 (UTC)
From: "Zemian Deng (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.12631797.1360611084281.106673.1374700669287@arcas>
In-Reply-To: <JIRA.12631797.1360611084281@arcas>
References: <JIRA.12631797.1360611084281@arcas>
Subject: [jira] [Updated] (CAMEL-6067) Provider deleteJob=true|false as an
 option for Quartz component
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CAMEL-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zemian Deng updated CAMEL-6067:
-------------------------------

    Attachment: CAMEL-6067.path

Here is a patch for this feature. Default is "deleteJob=true" 

Few notes on the changes.

1) Per my comment above, I have to remove the check on duplicate name when adding trigger to scheduler and NOT throw exception. (I fixed the QuartzNameCollisionTest as result of this.) This will now rely on user to ensure to give UNIQUE trigger name per endpoint, or they could be picking up an existing trigger for multiple endpoints!

2) If user decided to use "deleteJob=false", and then later changed the trigger name, then there is no way to delete the old trigger from the scheduler! You need to ensure they toggle the flag and have it removed before changing trigger name.

3) I have removed setStartTime(new Date()) and set similar behavior of trigger's MISFIRE_INSTRUCTION code instead. This allow the user to pick up existing trigger and reuse their misfire behavior if they like.

I have tested this path to some extends with a OracleXE database. Let me know what you think.

Zemian
                
> Provider deleteJob=true|false as an option for Quartz component
> ---------------------------------------------------------------
>
>                 Key: CAMEL-6067
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6067
>             Project: Camel
>          Issue Type: New Feature
>          Components: camel-quartz
>    Affects Versions: 2.10.2, 2.10.3
>            Reporter: Vishal
>            Priority: Minor
>             Fix For: 2.12.0, Future
>
>         Attachments: CAMEL-6067.path
>
>
> Although there is an option for defining stateful jobs in the quartz component via stateful=true, the jobs created are eventually deleted when Camel shutsdown. 
> Please see,
> http://camel.465427.n5.nabble.com/Quartz-triggers-being-deleted-when-shutting-down-Camel-tt5727257.html
> An option is needed to instruct Camel to not remove stateful jobs when coming down.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira