camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zemian Deng (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CAMEL-4075) Upgrade camel-quartz to Quartz 2.1.x
Date Thu, 25 Jul 2013 18:05:53 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719848#comment-13719848
] 

Zemian Deng edited comment on CAMEL-4075 at 7/25/13 6:05 PM:
-------------------------------------------------------------

Agree that "camel-quartz2" should be use because Quartz2.x API not only broke backward compatibility
to Quartz1.x, but they also renamed Trigger class into an interface, which can cause may problems
if you are not cleanly separate the two.

In my opinion, the current camel-quartz code seems to be a bit more complicated than it needs
to. For example there is no need to store JobDetail and Trigger objects in QuartzEndpoint
class. Also the associated name between JobDetail and Trigger should be more in sync since
Camel will always treat them as one-to-one relationship. It makes it more easier to manage
this way. Also, I don't think LoadBalancer is needed inside the QuartzEndpoint. Wouldn't it
make more sense to allow user configure this outside of the endpoint?

I would much prefer the camel-quartz2 to have a cleaner implementation and address more of
these minior things above.
                
      was (Author: saltnlight5):
    Agree that "camel-quartz2" should be use because Quartz2.x API not only broke backward
compatibility to Quartz1.x, but they also renamed Trigger class into an interface, which can
cause may problems if you are not cleanly separate the two.

In my opinion, the current camel-quartz code seems to be a bit more complicated than it needs
to. For example there is no need to store JobDetail and Trigger objects in QuartzEndpoint
class. Also the associated name between JobDetail and Trigger should be more in sync since
Camel will always treat them as one-to-one relationship. It makes it more easier to manage
this way. Also, I don't think LoadBalancer is needed inside the QuartzEndpoint etc.

I would much prefer the camel-quartz2 to have a cleaner implementation and address more of
these minior things above.
                  
> Upgrade camel-quartz to Quartz 2.1.x
> ------------------------------------
>
>                 Key: CAMEL-4075
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4075
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-quartz
>    Affects Versions: 2.7.2
>            Reporter: Claus Ibsen
>             Fix For: 2.12.0
>
>
> Quartz 2.0.1 has been released. We should upgrade the camel-quartz to use that version.
> There is an OSGi bundle in the works, to be pushed to central repo:
> http://repo2.maven.org/maven2/org/apache/servicemix/bundles/org.apache.servicemix.bundles.quartz/
> Also there is a SMX ticket
> https://issues.apache.org/jira/browse/SMXCOMP-884

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message