camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jeff (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-6367) The logic in stream producer should sync (lock) and not per method which is wrong
Date Mon, 20 May 2013 10:05:16 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13661877#comment-13661877
] 

jeff commented on CAMEL-6367:
-----------------------------

Thanks Willem,

As you can imagine, this example is just for explication.  We have a cascade ( lines are process
by more than 20 routes to enrich, reject, validate etc ) of direct route to process line of
CSV file.  

The fact that process reject or not a line is based on business rules which dones't care of
if it is the first or the last line. If I send the exchange to both endpoint if it is the
last line then  I duplicate the information in two " direction " which while cause dublication
in the rest of the file processing . 


Is there an elegant way to inform the file stream to close if it is the last line ( even if
for me it is not  to the camel user to manage the file used by the framework ) ?   

                
> The logic in stream producer should sync (lock) and not per method which is wrong
> ---------------------------------------------------------------------------------
>
>                 Key: CAMEL-6367
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6367
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-stream
>    Affects Versions: 2.11.0
>            Reporter: jeff
>
> A new option is available for the stream:file to close it when done (closeOnDone). This
option is appeared in 2.11 after my jira (https://issues.apache.org/jira/browse/CAMEL-6147)
> File unlock (or released or closed) looks to doesn't works fine if last line is not passed
to the endpoint
> Example :
> We have a CSV with X line. We want to write a part of it in a file out_1.csv and a second
part in a file out_2.csv according to a business rule, in my example the rule is after two
lines readed.
> An example is : 
> from("file://C:/Temp/camel/rep1/?noop=true")
>     .log("start process file => ${file:name}")
>     .split()
>     .tokenize("\n")
>         .streaming()
>         .process(new Processor() {
>          
>             public void process(Exchange exchange) throws Exception {
>                // After 2 lines, next lines are rejected via an exchange property
>                i++ ; 
>                if( i  > 2)  {
>                    exchange.setProperty("FILE_1", true );
>                } else {
>                    exchange.setProperty("FILE_1", false);
>                }
>             }
>        })
>        .choice()
>        .when(property("FILE_1").isEqualTo(Boolean.TRUE))
>            .to("stream:file?fileName=C:/Temp/camel/rep1/out/out_1.csv&closeOnDone=true")
>        .when(property("FILE_2").isEqualTo(Boolean.TRUE))
>             .to("stream:file?fileName=C:/Temp/camel/rep1/out/out_2.csv&closeOnDone=true")
>        .end()
>     .end()
> .log("end process file => ${file:name}")
> .end()
> ;
> It create two files, and out_1.csv is still locked.
> Solution : Seems like the logic in stream producer should sync (lock) and not per method
which is wrong.
> Or maybe better yet do not have a shared output stream.
> By the way, the problem appears not on if there are two files. It appears if the last
exchange is not passed to the endpoint.
> Example with only one file : 
> from("file://C:/Temp/camel/rep1/?noop=true")
>      .split()
>      .tokenize("\n")
>      .streaming()
>           .process(new Processor() {
>                public void process(Exchange exchange) throws Exception {
>                     // After 2 lines, next lines are rejected via an
>                     // exchange property
>                     i++;
>                     if (i > 2) {
>                          exchange.setProperty("FILE_1", false);
>                     } else {
>                          exchange.setProperty("FILE_1", true);
>                     }
>                }
>           })
>           .choice()
>           .when(property("FILE_1").isEqualTo(Boolean.TRUE))
>           .to("stream:file?fileName=C:/Temp/camel/rep1/out/out_1.csv&closeOnDone=true")
>           .end()
>      .end()
> .end();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message