Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Mon, 15 Apr 2013 13:24:17 +0000 (UTC)
From: "Babak Vahdat (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.12642489.1366010000567.167285.1366032257623@arcas>
In-Reply-To: <JIRA.12642489.1366010000567@arcas>
References: <JIRA.12642489.1366010000567@arcas>
Subject: [jira] [Updated] (CAMEL-6282) TypeConverterRegistry - Allow to
 enable or disable utilization statistics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CAMEL-6282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Babak Vahdat updated CAMEL-6282:
--------------------------------

    Attachment: the_idea.patch

Just for the sake of clarity I attach a local patch of what I'm trying to say. Then we could get rid of all those {{abstract}} methods at the level of {{AbstractCamelContextFactoryBean}} and make a unique implementation at the level of this class. With the attached patch in place I verified that the new tests of this ticket would still run green. I think the original intention of those abstract methods was to make use of the template pattern (the design pattern) but in this particular case the usage of this pattern doesn't make sense really much as we already know the unique implementation of these methods, both valid for Spring as well Blueprint IoC.

I will raise another ticket and work on it *after* 2.11 is out the door. Of course there're tons of other properties we would need to move up as well like {{useMDCLogging}}, {{autoStartup}}, {{threadNamePattern}}, etc.

Last but not least, thanks for your kind response :-)
                
> TypeConverterRegistry - Allow to enable or disable utilization statistics
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-6282
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6282
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.10.4
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.10.5, 2.11.1
>
>         Attachments: the_idea.patch
>
>
> We should disable it by default. And then allow people to turn it on, such as during development if they need to see easily if they are having to many misses etc. As that indicate a potential optimization, to avoid the many misses.
> We should disable by default as under high load the stats may cause a little performance degrade.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira