camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Müller (JIRA) <j...@apache.org>
Subject [jira] [Commented] (CAMEL-6116) Populate all optional parameters from DeliverSm (if it is DeliveryReceipt)
Date Thu, 07 Mar 2013 05:24:13 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595557#comment-13595557
] 

Christian Müller commented on CAMEL-6116:
-----------------------------------------

I'm wondering why we should not return the optional parameter values as Byte, Short, Integer
if the type is org.jsmpp.bean.OptionalParameter.Byte, org.jsmpp.bean.OptionalParameter.Short
or org.jsmpp.bean.OptionalParameter.Int.
For other parameter we already return Integer, Byte, ...

I trending to change this...
                
> Populate all optional parameters from DeliverSm (if it is DeliveryReceipt)
> --------------------------------------------------------------------------
>
>                 Key: CAMEL-6116
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6116
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-smpp
>            Reporter: Ioannis Alexandrakis
>            Assignee: Christian Müller
>              Labels: optional, parameters
>             Fix For: 2.11.0
>
>         Attachments: enableOptParamsOnReceipts.java.patch, enableOptParamsOnReceiptsv2.java.patch
>
>
> Hello all,
> I am currently working on a project requiring the use of camel-smpp. I stumbled upon
some problems integrating with the customer's SMSC, and I modified the code of camel-smpp
in order to fit my needs (just adding some functionality though, not removing any).
> More specifically, for submitting a new message, the delivery receipt held the corresponding
submit_sm id in the optional parameters (as receipted_message_id). With the current trunk
code, I did not get the optional parameters of the delivery receipt, so I could not match
the delivery receipt to the outgoing sms. As a solution I just looped all the optional parameters
and put them into a map as a header (and instead of checking each optional parameter name,
I just put whatever jsmpp was sending back, so if someone wants to put other optional parameters
to jsmpp too, they would simply automatically be populated back in camel-smpp.)
> Please find the patch attached

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message