Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Mon, 21 Jan 2013 20:52:13 +0000 (UTC)
From: "Babak Vahdat (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.12628455.1358676563271.169708.1358801533504@arcas>
In-Reply-To: <JIRA.12628455.1358676563271@arcas>
References: <JIRA.12628455.1358676563271@arcas>
Subject: [jira] [Resolved] (CAMEL-5983) Avoid the negative-tests to behave
 as false-positive
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CAMEL-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Babak Vahdat resolved CAMEL-5983.
---------------------------------

    Resolution: Fixed

All the remaining tests being mentioned by the previous post have been now fixed as well.
                
> Avoid the negative-tests to behave as false-positive
> ----------------------------------------------------
>
>                 Key: CAMEL-5983
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5983
>             Project: Camel
>          Issue Type: Task
>          Components: tests
>    Affects Versions: 2.10.3
>            Reporter: Babak Vahdat
>            Assignee: Babak Vahdat
>             Fix For: 2.10.4, 2.11.0
>
>         Attachments: CAMEL-5983-partial.patch
>
>
> We've got bunch of (negative) tests on the current codebase expecting a thrown {{XYZException}} however they don't realize if the expected exception is *not* thrown, the typical pattern for this is:
> {code}
> try {
>  doSomething_With_Expectation_Of_A_Thrown_XYZException();
> } catch (XYZException e) {
>  // expected
> }
> {code} 
> Which correctly should be:
> {code}
> try {
>  doSomething_With_Expectation_Of_A_Thrown_XYZException();
>  fail("Should have thrown an exception");
> } catch (XYZException e) {
>  // expected
> }
> {code} 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira