Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Thu, 10 Jan 2013 03:16:12 +0000 (UTC)
From: "Willem Jiang (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: <JIRA.12626690.1357692052021.111304.1357787772679@arcas>
In-Reply-To: <JIRA.12626690.1357692052021@arcas>
References: <JIRA.12626690.1357692052021@arcas>
Subject: [jira] [Commented] (CAMEL-5944) Setting extendMessageVisibility on
 an SQS consumer doesn't make visibilityTimeout compulsory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CAMEL-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549327#comment-13549327 ] 

Willem Jiang commented on CAMEL-5944:
-------------------------------------

Hi,

It makes sense that to check if the visibilityTimeout is set when the extendMessageVisibility option is true.
I will commit the patch shortly.

Willem
                
> Setting extendMessageVisibility on an SQS consumer doesn't make visibilityTimeout compulsory
> --------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-5944
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5944
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-aws
>    Affects Versions: 2.10.3
>            Reporter: Phil Cluff
>            Assignee: Tracy Snell
>            Priority: Minor
>         Attachments: CAMEL-5944-clean.patch
>
>
> The ExtendMessageVisibility functionality in SQS Consumer doesn't work unless visibilityTimeout is set (SqsConsumer.java L110), but the documentation doesn't sugggest this, and it isn't enforced.
> I'd suggest that we change the config/documentation such that visibilityTimeout becomes compulsory if extendMessageVisibility is set.
> Another option may be to check for available timeouts in the following order:
> 1) visibilityTimeout
> 2) defaultVisibilityTimeout
> 3) Fall back to a default value (30s?). [In this case, it would probably be sensible to log warning that we were using a default value.]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira