camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Babak Vahdat (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-5718) Bodies of SMs with 8-bit data_coding are mangled
Date Tue, 13 Nov 2012 08:11:12 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496034#comment-13496034
] 

Babak Vahdat commented on CAMEL-5718:
-------------------------------------

{quote}
I create a new Ubuntu VM and run the test locally. On my MacOS all tests pass.
{quote}

You can also reproduce the two failing tests even on MacOS:

{code}
mvn test -Dfile.encoding=UTF-16
{code}

That's you change the default platform encoding from {{MacRoman}} to {{UTF-16}}. Unfortunatley
I've got no knowledge of the SMPP protocol or jsmpp library but looking at the changes being
made by this ticket I see the configured encoding (that's {{SmppConfiguration.getEncoding()}})
[is not taken into the account *anymore*|http://svn.apache.org/viewvc/camel/trunk/components/camel-smpp/src/main/java/org/apache/camel/component/smpp/SmppBinding.java?r1=1395645&r2=1405775]
to build Strings out of the given byte arrays:

{code}
smppMessage.setBody(new String(deliverSm.getShortMessage()));
{code}

which explains why the test results are platform depended!

                
> Bodies of SMs with 8-bit data_coding are mangled
> ------------------------------------------------
>
>                 Key: CAMEL-5718
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5718
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-smpp
>            Reporter: Francois Kritzinger
>            Assignee: Christian Müller
>             Fix For: 2.9.5, 2.10.3, 2.11.0
>
>         Attachments: 8bit_deliver_sm_bodies_mangled.diff, camel_smpp_8bit_messages.diff
>
>
> Bytes in the body of 8-bit SUBMIT_SMs which do not fall within the chosen charset's range
are set to '?', which is obviously wrong because 8-bit/binary data should not be modified
in any way.
> EDIT: Turns out the RX SMs (DELIVER_SM, etc.) were also affected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message