Return-Path: X-Original-To: apmail-camel-issues-archive@minotaur.apache.org Delivered-To: apmail-camel-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 379BFC0AC for ; Wed, 6 Jun 2012 15:57:24 +0000 (UTC) Received: (qmail 47774 invoked by uid 500); 6 Jun 2012 15:57:24 -0000 Delivered-To: apmail-camel-issues-archive@camel.apache.org Received: (qmail 47731 invoked by uid 500); 6 Jun 2012 15:57:24 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 47723 invoked by uid 99); 6 Jun 2012 15:57:24 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2012 15:57:24 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id B97B214002E for ; Wed, 6 Jun 2012 15:57:23 +0000 (UTC) Date: Wed, 6 Jun 2012 15:57:23 +0000 (UTC) From: "Henryk Konsek (JIRA)" To: issues@camel.apache.org Message-ID: <2018939306.44003.1338998243761.JavaMail.jiratomcat@issues-vm> In-Reply-To: <579921795.42784.1338964343364.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Resolved] (CAMEL-5336) Improve Stream Component test coverage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CAMEL-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henryk Konsek resolved CAMEL-5336. ---------------------------------- Resolution: Fixed Ok, documentation updated. > Improve Stream Component test coverage > -------------------------------------- > > Key: CAMEL-5336 > URL: https://issues.apache.org/jira/browse/CAMEL-5336 > Project: Camel > Issue Type: Improvement > Components: camel-stream > Affects Versions: 2.9.2 > Reporter: Henryk Konsek > Assignee: Henryk Konsek > Fix For: 2.10.0 > > Attachments: stream-component-tests.patch > > > Hi, > I've improved the test coverage of Camel Stream component. > In particular I've added: > a) tests for Stream producer writing to the URL output stream (StreamToUrlTest). > b) assertions to StreamSystemOutTest. Previously we've been sending a messages to the System.out but made no assertions about it. This looked like the AssertionFreeTesting [1]. :) I changed the test to temporarily switch System.out with another PrintStream instance so we could make some assertions on it. > Could somebody take a look at patch and possibly apply it to the trunk? > [1] http://martinfowler.com/bliki/AssertionFreeTesting.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira