Mailing-List: contact issues-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Date: Wed, 11 Apr 2012 05:14:28 +0000 (UTC)
From: "Claus Ibsen (Commented) (JIRA)" <jira@apache.org>
To: issues@camel.apache.org
Message-ID: 
 <1418064774.11068.1334121268540.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1053178219.432.1333373244360.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CAMEL-5136) File producer should support a
 flush attribute
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/CAMEL-5136?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1325=
1323#comment-13251323 ]=20

Claus Ibsen commented on CAMEL-5136:
------------------------------------

We should use force on the file channel to flush the updates
http://docs.oracle.com/javase/6/docs/api/java/nio/channels/FileChannel.html=
#force(boolean)
               =20
> File producer should support a flush attribute
> ----------------------------------------------
>
>                 Key: CAMEL-5136
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5136
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.4, 2.9.1
>            Reporter: Jean-Baptiste Onofr=C3=A9
>            Assignee: Claus Ibsen
>             Fix For: 2.8.5, 2.9.2, 2.10.0
>
>
> Currently, the file operation doesn't flush the file change while writing=
 to the filesystem:
>     private void writeFileByFile(File source, File target) throws IOExcep=
tion {
>         FileChannel in =3D new FileInputStream(source).getChannel();
>         FileChannel out =3D null;
>         try {
>             out =3D prepareOutputFileChannel(target, out);
>             LOG.trace("Using FileChannel to transfer from: {} to: {}", in=
, out);
>             long size =3D in.size();
>             long position =3D 0;
>             while (position < size) {
>                 position +=3D in.transferTo(position, endpoint.getBufferS=
ize(), out);
>             }
>         } finally {
>             IOHelper.close(in, source.getName(), LOG);
>             IOHelper.close(out, target.getName(), LOG);
>         }
>     }
>     private void writeFileByStream(InputStream in, File target) throws IO=
Exception {
>         FileChannel out =3D null;
>         try {
>             out =3D prepareOutputFileChannel(target, out);
>             LOG.trace("Using InputStream to transfer from: {} to: {}", in=
, out);
>             int size =3D endpoint.getBufferSize();
>             byte[] buffer =3D new byte[size];
>             ByteBuffer byteBuffer =3D ByteBuffer.wrap(buffer);
>             int bytesRead;
>             while ((bytesRead =3D in.read(buffer)) !=3D -1) {
>                 if (bytesRead < size) {
>                     byteBuffer.limit(bytesRead);
>                 }
>                 out.write(byteBuffer);
>                 byteBuffer.clear();
>             }
>         } finally {
>             IOHelper.close(in, target.getName(), LOG);
>             IOHelper.close(out, target.getName(), LOG);
>         }
>     }
> It means that the file can be visible on the filesystem quite a long time=
 after starting to send the exchanges to the file endpoint.
> It could be interesting to add a flush attribute doing:
>     FileOutputStream os =3D ...
>     FileDescriptor fd =3D os.getFD();
>     ...
>     os.write(data);
>     os.flush();
>     fd.sync();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira