camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
Date Thu, 05 Apr 2012 06:53:43 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247064#comment-13247064
] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------


The fix works fine as we use this quote the matcher before using
{code}

    // must quote the names to have it work as literal replacement
        shortName = Matcher.quoteReplacement(shortName);
        longName = Matcher.quoteReplacement(longName);
{code}

However note that the syntax in Camel 2.10 has changed to use # instead of $ as tokens. This
avoids any confusions with property placeholders, simple language etc. The 2.9 and older releases
uses the $ to not break compatibility.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String)
method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method
will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message