camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadrian Zbarcea (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-5030) Allow smpp connection to be tunnelled through HTTP proxy
Date Tue, 28 Feb 2012 05:50:48 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217925#comment-13217925
] 

Hadrian Zbarcea commented on CAMEL-5030:
----------------------------------------

Hi Chris,

I looked into your patch and it's not bad but it required a bit of work. I had to fix a few
typos and add the proper version for commons-codec in the pom (I wonder how it passed your
tests, you probably had a hardcoded value when you tested). Then there were massive checkstyle
violations I had to fix as the jsch style doesn't quite jive with ours. I also added the header
indicating the origin of the code.

The method of reading proxy response line was a bit crude, I replaced that. I wonder if anything
could be done about the manual testing of the proxy and using dynamic ports. I will look into
that tomorrow.

                
> Allow smpp connection to be tunnelled through HTTP proxy
> --------------------------------------------------------
>
>                 Key: CAMEL-5030
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5030
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-smpp
>            Reporter: chris snow
>            Assignee: Hadrian Zbarcea
>         Attachments: camel-smpp-2.patch, camel-smpp.patch
>
>
> I can't use camel-smpp in my enterprise environment because all outbound connections
have to go through a proxy.  For SMPP, this means that using HTTP CONNECT is required similar
to the implementation here:
> https://github.com/rtyley/jsch/blob/master/src/com/jcraft/jsch/ProxyHTTP.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message