camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (Commented) (JIRA)" <>
Subject [jira] [Commented] (CAMEL-4796) Code Clean-Up
Date Fri, 06 Jan 2012 05:05:39 GMT


Claus Ibsen commented on CAMEL-4796:

The big patch I do not think is a good idea to apply on the 2.x versions. It touches almost
all files, makes backporting patches more problematic due source code difference.

For Camel 3.0 we can do this. Like we should also remove all the @version from the javadoc,
as they are pointless also.

So I suggest to work on minor code cleanups for 2.x. And postpone the big changes for 3.0.

> Code Clean-Up
> -------------
>                 Key: CAMEL-4796
>                 URL:
>             Project: Camel
>          Issue Type: Improvement
>    Affects Versions: 2.8.3
>            Reporter: Babak Vahdat
>            Assignee: Babak Vahdat
>             Fix For: 2.9.1, 2.10
>         Attachments: CAMEL-4796-@Deprecated-@Override.patch, CAMEL-4796-enhanced-for-loops.patch,
CAMEL-4796-obsolete-super-call.patch, CAMEL-4796-organize-imports-2.patch, CAMEL-4796-organize-imports.patch,
CAMEL-4796-remove-$NON-NLS$.patch, CAMEL-4796-remove-unnecessary-casts.patch
> This ticket aims to resolve the issues already mentioned in [1], but just to name them
ALL explicitly here:
> - Removal of the unused imports
> - Convert for loops to the enhanced one (supported since Java Tiger)
> - Removal of the obsolete "super();" call by the Constructors (Since JDK 1.0 compilers
already do it inside the byte-code for free!)
> - Remove of all $NON-NLS$ tags
> - Removal of the unnecessary casts
> - Usage of the @Deprecated & @Override annotations where required
> - Avoidance of the raw type declarations by the generified classes *as much as possible*
> - Removal of unused private memebers: Types, Constructors, Fields and Methods where applicable
> - Remove the trailing whitespace on *all* lines, even on the empty ones
> Add of missing serialVersionUID where required and default it to *1L* where serialVersionUID
has been already declared should be better postponed to the major 3.0.x release as otherwise
the backward-compatility would be broken on the 2.x.y release branches.
> If you can think of other possible clean-ups as well you may like to propose for including,
then please first better discuss it in [1] so that other commiters can better/faster/easier
react on it.
> I'll provide the patches *exactly in the same order* as mentioned above.
> Right now on the trunk my used IDE (eclipse) reports 1991 warnings!
> [1]

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message