camel-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CAMEL-4908) Twitter component fixes
Date Tue, 17 Jan 2012 13:31:40 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187673#comment-13187673
] 

Claus Ibsen commented on CAMEL-4908:
------------------------------------

Bilgin you may want to read about checkstyle, so you can run a test to run a report on the
command line, which tells you if the source code is aligned as it should (eg indent, parenthesis,
and whatnot)

See building with checkstyle here:
http://camel.apache.org/building.html

And btw I do not think you need to create a new ArrayList when you guard it as unmodified,
as the caller will not be able to modify the list.
return Collections.unmodifiableList(new ArrayList(receivedStatuses));

                
> Twitter component fixes
> -----------------------
>
>                 Key: CAMEL-4908
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4908
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-twitter
>    Affects Versions: 2.10.0
>            Reporter: Bilgin Ibryam
>             Fix For: 2.10.0
>
>         Attachments: twitter.diff
>
>
> Fix ConcurrentModificationException for StreamingConsumer.
> Fix NPE for FilterConsumer
> Use additional query parameters for FilterConsumer like userIds, keywords.
> I didn't added tests for these fixes, because currently it seems like it connects to
the internet and does real twitter queries. I will check this in a separate issue. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message