Return-Path: X-Original-To: apmail-camel-issues-archive@minotaur.apache.org Delivered-To: apmail-camel-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE75F9A56 for ; Thu, 22 Dec 2011 21:13:54 +0000 (UTC) Received: (qmail 99548 invoked by uid 500); 22 Dec 2011 21:13:54 -0000 Delivered-To: apmail-camel-issues-archive@camel.apache.org Received: (qmail 99529 invoked by uid 500); 22 Dec 2011 21:13:54 -0000 Mailing-List: contact issues-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list issues@camel.apache.org Received: (qmail 99522 invoked by uid 99); 22 Dec 2011 21:13:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2011 21:13:54 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD,URI_HEX X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2011 21:13:52 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id B7EAB12424F for ; Thu, 22 Dec 2011 21:13:30 +0000 (UTC) Date: Thu, 22 Dec 2011 21:13:30 +0000 (UTC) From: "Babak Vahdat (Commented) (JIRA)" To: issues@camel.apache.org Message-ID: <1650051767.40530.1324588410754.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1661584402.25819.1324291710649.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CAMEL-4796) Code Clean-Up MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CAMEL-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175064#comment-13175064 ] Babak Vahdat commented on CAMEL-4796: ------------------------------------- My used IDE seems to be too shy to tell me the whole truth in one single shot. So attached CAMEL-4796-organize-imports-2.patch which captures another 9 sources. Please note that as for example it's the case in [1] or [2] I don't aim to touch sources where the import has been commented out. [1] https://svn.apache.org/repos/asf/camel/trunk/tests/camel-itest-osgi/src/test/java/org/apache/camel/itest/osgi/jpa/JpaBlueprintRouteTest.java [2] https://svn.apache.org/repos/asf/camel/trunk/examples/camel-example-cxf-tomcat/src/main/java/org/apache/camel/example/cxf/CamelRoute.java > Code Clean-Up > ------------- > > Key: CAMEL-4796 > URL: https://issues.apache.org/jira/browse/CAMEL-4796 > Project: Camel > Issue Type: Improvement > Affects Versions: 2.8.3 > Reporter: Babak Vahdat > Assignee: Babak Vahdat > Fix For: 2.9.1 > > Attachments: CAMEL-4796-organize-imports-2.patch, CAMEL-4796-organize-imports.patch > > > This ticket aims to resolve the issues mentioned in [1], just to name some of them: > - organize imports > - avoid unnecessary cast > - add of missing serialVersionUID where required > If you can think of other possible clean-ups as well you may like to propose for including, then please first better discuss it in [1] so that other commiters can better/faster/easier react on it. > Right now on the trunk my used IDE (eclipse) reports 1991 warnings! > [1] http://camel.465427.n5.nabble.com/DISCUSS-Trunk-Code-Cleanup-td5071594.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira