camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [camel-k] astefanutti commented on a change in pull request #825: Misleading "service.enabled=false" when used in combination with the prometheus trait i
Date Wed, 17 Jul 2019 13:55:24 GMT
astefanutti commented on a change in pull request #825: Misleading "service.enabled=false"
when used in combination with the prometheus trait i
URL: https://github.com/apache/camel-k/pull/825#discussion_r304412676
 
 

 ##########
 File path: docs/modules/ROOT/pages/traits.adoc
 ##########
 @@ -367,6 +352,42 @@ It's disabled by default.
 
 !===
 
+| container
+| All
+| Configure integration contianer.
+  +
+  +
+  It's disabled by default.
+
+[cols="m,"]
+!===
+
+! container.request-cpu
+! The minimum amount of CPU required.
+
+! container.request-memory
+! The minimum amount of memory required..
+
+! container.limit-cpu
+! The maximum amount of CPU required.
+
+! container.limit-memory
+! The maximum amount of memory required.
+
+! container.service-port
+! To configure a different port exposed by the service (default `80`).
 
 Review comment:
   I find the phrasing a bit confusing. My understanding is that this parameter enables to
configure under which service port the container port is to be exposed. At least my brain
feels more confortable with the later definition 😉.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message