Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C50B2200D1A for ; Mon, 9 Oct 2017 22:54:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C38F91609CE; Mon, 9 Oct 2017 20:54:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3A8461609B8 for ; Mon, 9 Oct 2017 22:54:37 +0200 (CEST) Received: (qmail 6237 invoked by uid 500); 9 Oct 2017 20:54:36 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 6226 invoked by uid 99); 9 Oct 2017 20:54:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Oct 2017 20:54:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id EBCD4F5C9A; Mon, 9 Oct 2017 20:54:35 +0000 (UTC) From: BruceKuiLiu To: dev@camel.apache.org Reply-To: dev@camel.apache.org Message-ID: Subject: [GitHub] camel pull request #2017: Add an IfStatement to check the return value of ex... Content-Type: text/plain Date: Mon, 9 Oct 2017 20:54:35 +0000 (UTC) archived-at: Mon, 09 Oct 2017 20:54:38 -0000 GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/camel/pull/2017 Add an IfStatement to check the return value of executor.submit(task). This statement returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. The statement returns false if the file could not be successfully submitted (rather than throwing an Exception). If the result was not checked, developers would not notice if the statement signals an unexpected behavior by returning an atypical return value. http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE You can merge this pull request into a Git repository by running: $ git pull https://github.com/BruceKuiLiu/camel master3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2017.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2017 ---- commit 68f1fd275a1f56f8dde27df4c16170771924e458 Author: Kui LIU Date: 2017-10-09T20:52:47Z Add an IfStatement to check the return value of executor.submit(task). This statement returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. The statement returns false if the file could not be successfully submitted (rather than throwing an Exception). If the result was not checked, developers would not notice if the statement signals an unexpected behavior by returning an atypical return value. http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE ---- ---