camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] camel pull request #2017: Add an IfStatement to check the return value of ex...
Date Mon, 09 Oct 2017 20:54:35 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/camel/pull/2017

    Add an IfStatement to check the return value of executor.submit(task).

    This statement returns a value that is not checked.
    The return value should be checked since it can indicate an unusual or unexpected function
execution.
    The statement returns false if the file could not be successfully submitted (rather than
throwing an Exception).
    If the result was not checked, developers would not notice if the statement signals an
unexpected behavior by returning an atypical return value.
    http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/camel master3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2017.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2017
    
----
commit 68f1fd275a1f56f8dde27df4c16170771924e458
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-09T20:52:47Z

    Add an IfStatement to check the return value of executor.submit(task).
    
    This statement returns a value that is not checked.
    The return value should be checked since it can indicate an unusual or unexpected function
execution.
    The statement returns false if the file could not be successfully submitted (rather than
throwing an Exception).
    If the result was not checked, developers would not notice if the statement signals an
unexpected behavior by returning an atypical return value.
    http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE

----


---

Mime
View raw message