camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrlgohel <>
Subject [GitHub] camel pull request #1935: CAMEL-11771: Removed commons-logging import
Date Thu, 14 Sep 2017 14:57:49 GMT
GitHub user vrlgohel opened a pull request:

    CAMEL-11771: Removed commons-logging import

    Switched to slf4j Logging, replacing commons-logging. 
    camel-cxf has some tests, which still make use of commons-logging. The tests in package,
org.apache.camel.component.cxf.mtom with class MtomTestHelper.isAwtHeadless method referencing
to few other test classes in the same package. 
    The logger value used comes from org.springframework.test.context.junit4.AbstractJUnit4SpringContextTests.logger
and this internally uses commons-logging,
    Hence, i am not sure if we need to make any changes here. 
    For the rest, tested with the build, tests & itests,  i see no issues. 

You can merge this pull request into a Git repository by running:

    $ git pull CAMEL-11771

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1935
commit 7fe2bfee68edfbff6dc5532ea479e2ef4174ba70
Author: Viral Gohel <>
Date:   2017-09-14T14:43:26Z

    CAMEL-11771: Removed commons-logging import



View raw message