camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: [HEADS UP] Revision of CamelContext startup/stoppage with Spring is now in master
Date Wed, 31 May 2017 06:58:33 GMT
On Tue, May 30, 2017 at 11:19 AM, Zoran Regvart <zoran@regvart.com> wrote:
> Hi,
> yes, the issue is with the `noStart` flag in `SpringCamelContext` the
> contract of which I changed with CAMEL-11261, it used to mean: do not
> start automatically, but only on `CamelContext::start()` with my
> change it means do not start unless set to `false`. I've created a PR
> against wildfly-camel[1] that should help.
>
> But I think it would be better to remove `noStart` flag from
> SpringCamelContext, we could do a SpringCamelContextCustomizer or such
> interface that will be applied before SpringCamelContext is started
> (for instance on afterPropertiesSet) and wildfly-camel and tests can
> use this to set `autoStartup` flag to `false`.
>
> If we're going to keep the `noStart` flag, then I think I need to
> rework it to work like it did before CAMEL-11261, I don't know if
> there are any other projects that might be affected by this change in
> behaviour.
>

I would not think there are many other projects as wildfly-camel is an
extension to bring Camel to run on WildFly via the JBoss Module
System. Most Camel users are end users and Camel runs well on other
platforms and containers out of the box.



> zoran
>
> [1] https://github.com/wildfly-extras/wildfly-camel/pull/1890
>
> On Tue, May 30, 2017 at 11:12 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
>> Hi
>>
>> Did you guys find out the problem with wildfly-camel ?
>>
>> And wonder if people from the community could give this a test on
>> their camel spring apps? For example I think there was an user
>> reported about this shutdown problem a while back, that lead to this
>> solution. Maybe that person can give this a test?
>>
>> On Mon, May 29, 2017 at 9:29 AM, Zoran Regvart <zoran@regvart.com> wrote:
>>> Hi Cameleers,
>>> I've merged PR#1685[1] for CAMEL-11261[2] the revision of the way
>>> CamelContext is started/stopped when used with Spring framework.
>>>
>>> Based on the amount of intertwined functionality that we have with
>>> Spring this has the potential to break things in unexpected places, so
>>> please get back to me so I can troubleshoot any bugs you find.
>>>
>>> I already had an issue reported[3] by the wildfly-camel team that I'm
>>> looking into, please keep those coming as you encounter any.
>>>
>>> On a sidenote, I've seen a strange behaviour when Maven uses outdated
>>> version of `camel-test-spring` from the local repository; so, if
>>> possible, before reporting please remove Camel artifacts from the
>>> local repository (mvn -Pcleanrepo) and install the latest SNAPSHOT
>>> (mvn -Pfastinstall clean install). With any luck the CI builds with
>>> the newer version will pass soon so we'll have those SNAPSHOTS in the
>>> Apache repository so this will not be needed.
>>>
>>> zoran
>>>
>>> [1] https://github.com/apache/camel/pull/1685
>>> [2] https://issues.apache.org/jira/browse/CAMEL-11261
>>> [3] https://github.com/wildfly-extras/wildfly-camel/issues/1889
>>> --
>>> Zoran Regvart
>>
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>
>
>
> --
> Zoran Regvart



-- 
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

Mime
View raw message